search

dfellis / h3-node

H3 binding to Node using N-API
MIT License
30 stars 5 forks source link

Integer array API #40

Closed isaacbrodsky closed 3 years ago

isaacbrodsky commented 3 years ago

Applies the change in uber/h3-js#91 to h3-node. There is a slight difference that invalid index objects cause the library to throw instead of returning false from h3IsValid; not sure if we want to bring that into consistency. I'm sure we could also add better testing for this change, perhaps test that h3ToGeo behaves the same with both forms of input?

dfellis commented 3 years ago

Will wait for @nrabinowitz to also approve and then I will merge it.