search

dfherr / LibThreatClassic2

A library for multi-target threat tracking in WoW Classic. Successor of ThreatClassic-1.0
GNU Lesser General Public License v2.1
16 stars 13 forks source link

Fixed missed threat abilities causing threat #30

Closed emrus-main closed 4 years ago

emrus-main commented 4 years ago

This pull request corrects that warrior abilities no longer applies their flat threat modifier when the ability is missed, dodged or parrried.

It's not fully tested for blocks and immunities. But, it's still more correct then the current state.

This changed is based on a Vael wipe last night where threat meter showed the tank as way ahead, however a dps warrior pulled aggro regardless. The discrepency lines up exactly with lib believing that missed abilities caused threat, and the game not.

This also agrees with the threat analysis site http://82.130.21.56/threat/, which also doesn't credit misses with threat

Log Tank: https://classic.warcraftlogs.com/reports/PXFzHGnba9AgfctK/#type=summary&fight=5&view=events&source=10 Log DPS: https://classic.warcraftlogs.com/reports/PXFzHGnba9AgfctK/#type=summary&fight=5&view=events&source=17 Video: (Fight starts at 00:16:51) https://www.twitch.tv/videos/586576228 Spreadsheet: https://docs.google.com/spreadsheets/d/1IUk2yrDuR7l-R8uN9phKlxttcYP1NfXlsUQ3kpdZp4A/edit?usp=sharing

dfherr commented 4 years ago

Hi,

thanks for contributing and raising this issue!

I implemented the suggestion of removing bonus threat on misses (which includes blocks) for all abilities and all classes. I didn't merge this as the PR contained errors (using value instead of key for the CastMissHandler), it didn't solve the issue for all classes and contained a version bump.

emrus-main commented 4 years ago

Good catch on the value vs key!