search

dfherr / LibThreatClassic2

A library for multi-target threat tracking in WoW Classic. Successor of ThreatClassic-1.0
GNU Lesser General Public License v2.1
16 stars 13 forks source link

BOS threat bug - counting event when not buffed #35

Closed Orvisky closed 4 years ago

Orvisky commented 4 years ago

Hello, we found bug that this lib count BOS even if we dont have it buffed. BOS got overbuffed by another paladin with PallyPower but TinyThreat and also ClassicThreatMeter2 counting still as BOS buffed and doing bad numbers in threat meters and confusion.

Attaching screenshot from BWL 12.4., Main Tank screenshot, Vaelstraz Main tank ofc didnt have BOS on him when battle starts. Sam ething happened 27.4.

When we simulated BOS in threat chart on MT http://82.130.21.56/threat/, threat numbers matched with addon data.

image

Orvisky commented 4 years ago

@dfherr can you pls tell me, in which event calcBuffMods is called? If i am assumg right, this functions is causing recalc of threat modifiers. It is possible to call it manually?

Or what happend e.g. if pala buffed me with BOS, and another pala rebuff me 1-2 sec later with BOL. BOS logically dissapers, but does this library call calcBuffMods and know that i dont have BOS?

Thank you

Orvisky commented 4 years ago

Or maybe is there possibility to do some command to recount buffs / print actual buffThreatMultipliers to see if everything is ok?

dfherr commented 4 years ago

Hi,

thanks for reporting this issue. This is already known and already fixed. See here: https://github.com/dfherr/LibThreatClassic2/issues/8#issuecomment-617000578

I will release the fix with the next revision soon.