search

dfieschko / RP1210

A Python32 implementation of the RP1210C standard. Now with 100% test coverage!
MIT License
20 stars 12 forks source link

RP1210API.GetErrorMsg should fall back to translating the error message rather than translating GetErrorMsg's return code. #75

Closed dfieschko closed 2 years ago

dfieschko commented 2 years ago

When a user calls GetErrorMsg, they want a translation of their error code. If RP1210_GetErrorMsg returns a code, we don't want to translate that instead of ErrorMessage, since that's confusing.

Instead of:

return translateErrorCode(ret_code)

We should have:

return translateErrorCode(ErrorCode)