Fixing RequestDownload and RequestUpload - Githubissues

dfieschko / RP1210

A Python32 implementation of the RP1210C standard. Now with 100% test coverage!

MIT License

20 stars 12 forks source link

Fixing RequestDownload and RequestUpload #99

Closed kali-muon closed 2 years ago

kali-muon commented 2 years ago

In the UDS standard, RequestDownload and RequestUpload messages do not have DIDs. This PR updates the associated classes to reflect that, and adds some extra functionality to them.

✨ Enhancements

Fleshed out constructors for RequestDownloadRequest and RequestUploadRequest to enable setting each message field individually.
Implemented automatically calculating the ALFID for RequestDownloadRequest and RequestUploadRequest. Enabled by default, but can be disabled with constructor parameters.

🗿 Miscellaneous

Updated tests to reflect the changes to RequestDownload and RequestUpload.

👀 Checklist

[x] Did you test your changes?
[x] Do the unit tests all pass?
[x] Do the examples still work?
[x] Are there any failing workflows?
[x] Is version in setup up-to-date?