search

dfilatov / vidom

Library to build UI based on virtual DOM
MIT License
415 stars 16 forks source link

SSR issues #118

Closed ghost closed 9 years ago

ghost commented 9 years ago

Contenteditable should be ignored during SSR.

Reference: https://github.com/ractivejs/ractive/blob/dev/src/virtualdom/items/Element/prototype/toString.js#L34-L37

And should you escape the value of a textarea? Because after what I understand, both select and textarea values shouldn't be stringified.

dfilatov commented 9 years ago

select and textarea values aren't stringified.

dfilatov commented 9 years ago

I can't understand from this source why contenteditable shouldn't be stringified. Could you provide any details?

ghost commented 9 years ago

Ignored. In some cases this attribute ends up like contentEditable="" and shouldn't be set at all. There are other issues as well. See my issue ticket about this attribute and inherit

ghost commented 9 years ago

And also sometimes value has to be set before contentEditable to work and vice versa. Also in table rows this attr can cause issues

dfilatov commented 9 years ago

"SSR issues", "In some cases", "There are other issues as well" — it's not a good description. Please attach example of non-working code!