search

dfilatov / vidom

Library to build UI based on virtual DOM
MIT License
415 stars 16 forks source link

Issue with using Component in IE10 #198

Closed tnajdek closed 8 years ago

tnajdek commented 8 years ago

All the test use createComponent directly and that ideed works fine in IE10 so the tests pass. However if the library is used as per the tutorial it will not work in IE10 where it errors with:

Unable to get property 'renderToDom' of undefined or null reference

This can be observed on the official demo: http://dfilatov.github.io/vidom-todomvc/

A simple workaround is to use createComponent directly. Only IE10/IE9 are affected.

screen shot 2016-04-14 at 13 11 41
dfilatov commented 8 years ago

Hi, @tnajdek! Thanks for the report. The problem isn't with vidom itself, it's a consequence of usage babel stuff, see http://babeljs.io/docs/usage/caveats/ for details. I've added babel-plugin-transform-proto-to-assign to the build pipeline for vidom-todomvc and now it's working as expected. Please, try it once more and give me feedback if something is going wrong.

tnajdek commented 8 years ago

ahh, that makes sense, thanks!