coveralls
commented
4 years ago Pull Request Test Coverage Report for Build 32
- 18 of 27 (66.67%) changed or added relevant lines in 1 file are covered.
- 3 unchanged lines in 1 file lost coverage.
- Overall coverage increased (+0.02%) to 67.188%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| index.js | 18 | 27 | 66.67% | ||
| <!-- | Total: | 18 | 27 | 66.67% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| index.js | 3 | 67.19% | ||
| <!-- | Total: | 3 | --> |
| Totals | |
|---|---|
| Change from base Build 29: | 0.02% |
| Covered Lines: | 41 |
| Relevant Lines: | 62 |
wanderer
ameba23
Use herumi/bls-wasm instead of dfinity/js-bls-lib.
This is different bindings to the same underlying BLS library. These binding are maintained by the author of that C++ library, so (perhaps) more likely to be updated with changes to that library.
The API is almost the same, except some methods no longer require passing in an instance of the bls library. If we dont want an API breaking change we could allow the library to be passed in anyway.
If you'd rather not merge this, no problem, but let me know cos i would probably publish it to npm under another name.
Note that if merging we would need to rebuild the documentation as it contains absolute links which currently point to the fork.
@wanderer