search

dfinity-side-projects / js-dfinity-block

This library provides basic functions for creating serializing and deserializing blocks
18 stars 4 forks source link

An in-range update of tweetnacl is breaking the build 🚨 #15

Open greenkeeper[bot] opened 4 years ago

greenkeeper[bot] commented 4 years ago

The dependency tweetnacl was updated from 1.0.1 to 1.0.2.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

tweetnacl is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details - ❌ **continuous-integration/travis-ci/push:** The Travis CI build failed ([Details](https://travis-ci.org/dfinity-side-projects/js-dfinity-block/builds/638104445?utm_source=github_status&utm_medium=notification)).
FAQ and help There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 4 years ago

After pinning to 1.0.1 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.

greenkeeper[bot] commented 4 years ago

Your tests are still failing with this version. Compare changes

Release Notes for Important security fix

IMPORTANT BUG FIX. Due to a bug in calculating carry in
modulo reduction that used bit operations on integers larger than
32 bits, nacl.sign or nacl.sign.detached could have created
incorrect signatures.

This only affects signing, not verification.

Thanks to @valerini on GitHub for finding and reporting the bug.

Commits

The new version differs by 4 commits.

See the full diff