search

dfinity-side-projects / js-libp2p-gossip-discovery

implements peer discovery using a gossip protocol
GNU General Public License v3.0
23 stars 6 forks source link

Use 4 bytes to store peer book size #11

Closed mslipper closed 6 years ago

mslipper commented 6 years ago

The peer book's size could only fit in 1 byte, so the JSON payload could only be 255 bytes in length. I've updated this to use a uint32, which should fit most use cases.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.9%) to 97.333% when pulling 66b1dfaa214836f9979d5015d4c09f79b45b391c on mslipper:larger-byte-size into bae95eb1558afc1f1b7d18a1c01a3533511758cf on dfinity:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 98.206% when pulling 19efe6662ca3253358d229b0e65f139da9dae7b2 on mslipper:larger-byte-size into bae95eb1558afc1f1b7d18a1c01a3533511758cf on dfinity:master.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.02%) to 98.222% when pulling 0e46925893ec7ab7535ebe2efb9701508f26cd56 on mslipper:larger-byte-size into bae95eb1558afc1f1b7d18a1c01a3533511758cf on dfinity:master.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.02%) to 98.222% when pulling 0e46925893ec7ab7535ebe2efb9701508f26cd56 on mslipper:larger-byte-size into bae95eb1558afc1f1b7d18a1c01a3533511758cf on dfinity:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 98.206% when pulling 3f2fb660391e0d8ca164d41b50bec639b5deb4e8 on mslipper:larger-byte-size into bae95eb1558afc1f1b7d18a1c01a3533511758cf on dfinity:master.

wanderer commented 6 years ago

@mslipper looks good!