Closed seniorjoinu closed 3 months ago
// returns the certificate
const { result, cert } = await canister.do_stuff.withOptions({ returnCertificate: true })(args);
// works as usual, if executed without options
const result = await canister.do_stuff();
// works as usual, if `returnCertificate` option is unset
const result1 = await canister.do_stuff.withOptions({ canisterId: cid })(args);
// works as usual, if `returnCertificate` option is `false`
const result3 = await canister.do_stuff.withOptions({ returnCertificate: false })(args);
// typescript will throw an error
const result = await canister.do_stuff.withOptions({ returnCertificate: true })(args);
processResult(result); // <- result is type { result: Result, cert: ArrayBuffer } and not just Result
// typescript will throw an error
const { result, cert } = await canister.do_stuff(); // <- type Result has no fields "cert", "result"
I'll need to think a little more about the design of modifying the return signature based on an option. I might want to take a slightly different approach to the API, but I do appreciate the work you've done on this
@krpeacock
I'll need to think a little more about the design of modifying the return signature based on an option. I might want to take a slightly different approach to the API, but I do appreciate the work you've done on this
We could also do this as a separate method, similar to .withOptions
. Something like .andCertificate()
. The reason why I didn't do this in the first place is because in that case we would probably need two of those: one regular and one with http details. This would be better for JS without TS setups.
I could implement that very quickly, just say your word. We need that feature for our project asap, so I would do whatever it takes.
Also, what do you think about the fixing part? Was there a bug in pollForResponse
or not?
@krpeacock pinging you once again. Hope it is fine.
Description
It is possible to speed up inter-canister calls in some scenarios, if delegate making the call and transferring the response to the user. For example, you've make an ICRC-1 token transfer to some dApp. This dApp, instead of making its own inter-canister call to token's index canister, would ask the user itself to fetch the block from the index and pass the certified response back to one of its own canisters, which can then verify the response.
Such an optimization requires being able to make a call and simultaneously retrieve the raw certificate client-side. This PR adds this feature in a clean non-breaking way.
Also, there was an accidentally discovered bug related to
pollForResponse
function. It was invoked withblsVerify
parameter in place ofrequest
parameter. Maybe it did nothing, but it seemed suspicious. This wasn't catched by Typescript, becauserequest
parameter is of typeany
.Note
CallConfig.returnCertificate
is set totrue
. In that case, instead of justreply
the method will return{ result: reply, cert: rawCertificate }
. IfCallConfig.returnCertificate
is unset offalse
- nothing changes, everything works as usual.update
calls. Forquery
calls empty buffer is returned like this{ result: reply, cert: emptyBuf }
. This is done to: a) comply with method signature change (ActorMethod interface is the same for query and update calls); b) enable replica signature/certificate to be returned the same way for queries in future.How Has This Been Tested?
Added a unit-test to
actor.test.ts
testcase.