dfinity / agent-js

A collection of libraries and tools for building software around the Internet Computer, in JavaScript.

https://agent-js.icp.xyz

Apache License 2.0

155 stars 96 forks source link

feat: refactor nonce specification in HttpAgent #944

Open krpeacock opened 1 month ago

krpeacock commented 1 month ago

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Fixes # (issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Checklist:

[ ] My changes follow the guidelines in CONTRIBUTING.md.
[ ] The title of this PR complies with Conventional Commits.
[ ] I have edited the CHANGELOG accordingly.
[ ] I have made corresponding changes to the documentation.

krpeacock commented 1 month ago

@frederikrothenberger a WIP, but related to #941 changes, allowing nonce to be passed directly to call and query on the agent

I'll need to add support for taking advantage of this when using an Actor by adding nonce to withOptions before it's ready

github-actions[bot] commented 1 month ago

size-limit report 📦

Path	Size
@dfinity/agent	86.08 KB (+0.07% 🔺)
@dfinity/candid	13.58 KB (0%)
@dfinity/principal	4.97 KB (0%)
@dfinity/auth-client	60.36 KB (0%)
@dfinity/assets	81.19 KB (0%)
@dfinity/identity	57.56 KB (0%)
@dfinity/identity-secp256k1	131.36 KB (+0.04% 🔺)