search

dfinity / cancan

A scalable video sharing service.
http://sdk.dfinity.org
Apache License 2.0
335 stars 65 forks source link

Fix ic-repl-based CI tests to do authentication correctly. #22

Closed matthewhammer closed 3 years ago

matthewhammer commented 3 years ago

This started as another PR, but seems to require its own lifespan.

Will resolve this with help from ic-repl author @chenyan-dfinity, with some new release, likely.

matthewhammer commented 3 years ago

@chenyan-dfinity Has looked at this and has concluded that ic-repl needs to adapt to handle the wallet-based identity that dfx creates when building CanCan locally.

chenyan-dfinity commented 3 years ago

@matthewhammer The error seems to be expected. There is no abuseFlags in getVideoInfo. Only abuseFlagUsers

matthewhammer commented 3 years ago

Okay, the API changed and the test was never updated.

I think the other changes you made were necessary though (--no-wallet).

Without that, I was getting stuck earlier in the test on createTestData and all of the queries, by getting null when I expected non-null in each case.

I didn't realize that --no-wallet existed or that it would help here. Thanks!

matthewhammer commented 3 years ago

This is an old attempt.

Re-trying now with #25