dfinity / cycles-wallet

DFINITY Cycles Wallet
Apache License 2.0
55 stars 30 forks source link

Feat: SDK-208 frontend multiple controllers #114

Closed wackyleo459 closed 2 years ago

wackyleo459 commented 2 years ago

SDK-208: Enables multiple controllers when creating a new canister.

First entry is pre-populated with cycles wallet (which is editable). User can add as many controllers as needed. The create canister button does end up creating the canister. (Once you refresh the page)

*Note: There is an error of : "Fail to verify certificate", during polling process. This can be addressed in another branch. Please locally test on your own computer if you get same error.

For local development try out: Please replace line 18 in wallet_ui/utils/s/authClient.ts file with your locally deployed internet identity canister. https://github.com/wackyleo459/cycles-wallet/blob/sueann/main/wallet_ui/utils/authClient.ts#L18

@krpeacock @adamspofford-dfinity

wackyleo459 commented 2 years ago

SDK-208: https://github.com/dfinity/cycles-wallet/pull/114#issue-1085292467 Canister is successfully created with single or multiple controllers.

Note:

wackyleo459 commented 2 years ago

Feedback has been resolved.

Please view walkthrough recording here.

Note: Creating canisters with 0 cycles, error handling will be included in next ticket