dfinity / cycles-wallet

DFINITY Cycles Wallet
Apache License 2.0
55 stars 30 forks source link

feat: wallet_call_with_max_cycles #170

Closed sesi200 closed 7 months ago

sesi200 commented 7 months ago

When the wallet is used to withdraw as many cycles as possible from a canister that will be deleted shortly, one wants to withdraw whatever is available. With this function it's no longer necessary to use heuristics to guesstimate how many cycles can be withdrawn.

Bumping the Rust version because

error: failed to compile `ic-wasm v0.7.1`, intermediate artifacts can be found at `/tmp/cargo-installLIevpn`

Caused by:
  package `clap_builder v4.5.2` cannot be built because it requires rustc 1.74 or newer, while the currently active rustc version is 1.70.0
lwshang commented 7 months ago

Could you add a test?