dfinity / cycles-wallet

DFINITY Cycles Wallet
Apache License 2.0
55 stars 30 forks source link

feat: add identity provider integration #40

Closed hansl closed 3 years ago

hansl commented 3 years ago

Done the following:

hansl commented 3 years ago

Next time please just advertise your intentions

I'm sorry, my bad for this. I thought I mentioned it in our 1:1 that my target was to implement this. Even if so, I should have made it clearer and written down.

If we do it this way, do you think this will serve as a good example for how open-chat can do it in localdev, their current ic0.app deployment on sodium, etc? starting (for them to use) on Monday.

Yes. But we should move the AuthenticationClient to our own packages, otherwise that file will just keep popping up copy pasted everywhere (which works here as a PoC but not as a real solution).

gobengo commented 3 years ago

hans:

I'll let you merge.