dfinity / dfxvm

dfx version manager

Apache License 2.0

7 stars 5 forks source link

fix: tests failing with "text file busy" #26

Closed ericswanson-dfinity closed 10 months ago

ericswanson-dfinity commented 10 months ago

Description

I have noticed tests failing like this, but more often recently:

Failed to spawn HOME="/tmp/dfxvm-integration-tests-homeUbf1FB" 
   "/tmp/dfxvm-integration-tests-homeUbf1FB/dfx": 
  Text file busy (os error 26)

This PR makes two changes:

don't re-create a copy of dfxvm with a given name
when creating any executable, try to execute it until anything other than os error 26 happens

How Has This Been Tested?

I ran tests with three branches, modified to run the tests without an open PR and to set RUST_BACKTRACE=1:

same as main (workflow): 8 failures out of 20 attempts
do not re-create dfxvm binaries (workflow): 15 failures out of 20 attempts
this branch (workflow): 0 failures out of 20 attempts