dfinity / examples

Example applications, microservices, and code samples for the Internet Computer
https://dfinity.org
Apache License 2.0
537 stars 362 forks source link

chore(FI-1221): Bump the version of the ICP Ledger canister #729

Closed mbjorkqvist closed 7 months ago

mbjorkqvist commented 7 months ago

chore(FI-1221): Bump the version of the ICP Ledger canister

Overview The rust-tokens_transfer and motoko-ledger-transfer tests are currently failing (e.g., in this job of this PR) since they try to download a version of the ICP ledger that is over 1,5 years old, and the file no longer exists at https://download.dfinity.systems/ic/2cb0afe1f49b8bbd4e60db234ca1f4a6f68ea115/canisters/ledger-canister_notify-method.wasm.gz .

Requirements If the following tests pass, then this problem can be considered solved:

Considered Solutions Ideally, this version should be updated whenever the ICP Ledger on mainnet is updated.

Recommended Solution Updating the hard-coded version is the recommended solution for now.

Considerations The recommended solution should improve the developer experience, but it will not reduce the maintenance work.

letmejustputthishere commented 7 months ago

hey @mbjorkqvist , i already updated the examples in this PR

https://github.com/dfinity/examples/pull/722

mbjorkqvist commented 7 months ago

hey @mbjorkqvist , i already updated the examples in this PR

722

Excellent, thanks! I'll go ahead and close this PR then.