search

dfinity / examples

Example applications, microservices, and code samples for the Internet Computer
https://dfinity.org
Apache License 2.0
508 stars 324 forks source link

fix: [VER-2721] rust/basic_dao #851

Closed michael-weigelt closed 2 months ago

michael-weigelt commented 2 months ago

This MR fixes the basic_dao examples.

ninegua commented 2 months ago

I had a look at the motoko invoice canister test failures:

  1. A canister id was hardcoded in the test, which is brittle. Recent dfx nns install would install more canisters, so the hardcoded canister id no longer matches. This can be temporarily fixed by hardcode the new correct canister id. But it will be better to have a more permanent fix.
  2. The motoko code uses Principal module to encode/decode extended text form of ICRC account, and this breaks in the recent motoko base lib because Principal would reject blobs longer than 32-byte. It requires a non-trivial fix that I don't think would suit this MR.

The rust-nft-wallet failures seem to be non-deterministic, as can be seen in these two runs: 8844360961 and 8844006204. I haven't looked too close yet.