Removing the Bank of Israel

dfinity / exchange-rate-canister

The exchange rate canister (XRC) makes use of the HTTP requests feature to provide exchange rates as a service to the IC.

Apache License 2.0

37 stars 10 forks source link

Closed THLO closed 1 year ago

THLO commented 1 year ago

The XRC does't get forex rates from the Bank of Israel. This PR removes this forex source to make sure that the XRC doesn't make useless calls.

yotamhc commented 1 year ago

Meta-comment on the PR description:

neither over IPv4

It does work over IPv4, but the way HTTPS outcalls work is that if a URL resolves to IPv6 the request is made over IPv6...

THLO commented 1 year ago

It does work over IPv4, but the way HTTPS outcalls work is that if a URL resolves to IPv6 the request is made over IPv6...

Yes, you are right. I meant that we cannot get a rate regardless of whether or not IPv4 support is available. I updated the comment.