dfinity / exchange-rate-canister

The exchange rate canister (XRC) makes use of the HTTP requests feature to provide exchange rates as a service to the IC.
Apache License 2.0
37 stars 10 forks source link

chore: Bump candid from 0.10.2 to 0.10.10 #267

Closed dskloetd closed 1 month ago

dskloetd commented 1 month ago

Motivation

I want to copy the xrc_mock canister from the subnet-rental-canister repo to this repo and make the wasm available in a release so that I can download it in the test environment script for NNS dapp.

When working on that I ran into problems caused by a mismatch in dependencies. After fixing that, running scripts/build-wasm resulted in some warnings that weren't there before.

So I thought it would be best to update the dependencies and fix the warnings in a separate PR first, before importing the mock canister.

Changes

  1. Changed the candid dependency in Cargo.toml from 0.10.2 to 0.10.10.
  2. Deleted Cargo.lock
  3. Ran scripts/build-wasm and addressed warnings until all warnings were gone.

Tests

I'm assuming that when the warning tells me to do X instead of Y, that those functions do the same things. But I have not checked or verified this. I'm counting on GitHub CI running enough tests. If there is any manual testing that needs to be done, let me know.