dfinity / interface-spec

IC Interface Specification
https://khsfq-wqaaa-aaaak-qckvq-cai.icp0.io/docs
37 stars 20 forks source link

add clarification for whitespace in the ic-certificateexpression header #238

Closed nathanosdev closed 1 year ago

nathanosdev commented 1 year ago

This PR removes some whitespace in the EBNF specification of the IC-CertificateExpression header. Our current implementation is whitespace agnostic, but the specification should be clear that there is no whitespace allowed in the value of this header. I've also added a note that implementers can also optionally allow for whitespace.

Some other minor changes are a result of Prettier formatting.

Thanks @frederikrothenberger for bringing this up: https://dfinity.slack.com/archives/CN4SJRNG4/p1696930887498429

This change could actually break an implementation of this spec, if there was such an implementation out there that took the EBNF literally and did not account for any whitespace flexibility. We're not currently aware of any implementations aside from our own, which is agnostic of whitespace: https://github.com/dfinity/response-verification

nathanosdev commented 1 year ago

Thanks @oggy-dfin, I've applied your suggestions

nathanosdev commented 1 year ago

Thanks @Dfinity-Bjoern