search

dfinity / interface-spec

IC Interface Specification
https://khsfq-wqaaa-aaaak-qckvq-cai.icp0.io/docs
37 stars 20 forks source link

add convenience types for canister management methods #275

Closed letmejustputthishere closed 9 months ago

letmejustputthishere commented 9 months ago

i formatted the document for a consistent style and added the missing convenience types to close #269

letmejustputthishere commented 9 months ago

thank you for reviewing! i implemented the requested changes

mraszyk commented 9 months ago

Thank you for implementing my comments. Left two more, but I'm happy to approve after the typo comment is resolved (i.e., the bitcoin types can be kept duplicated if you prefer).

letmejustputthishere commented 9 months ago

this is ready to merge :)

peterpeterparker commented 9 months ago

While synchronizing the DID types in ic-js, I noticed unexpected format differences in @dfinity/ic-management, given that we sync the IC management types from this repo.

May I ask why the format was changed, what tool was used to format the DID files, and whether the format will be guaranteed to remain consistent for future iterations?

Capture d’écran 2024-02-26 à 11 57 33
letmejustputthishere commented 9 months ago

why the format was changed

before those changes the file wasn't formatted consistently

what tool was used to format the DID files

the motoko language extension was used (it can format did files)

the format will be guaranteed to remain consistent for future iterations?

probably only if we specify it

peterpeterparker commented 9 months ago

Thanks for the feedback. In the future, it would be great if we can remain consistent. It makes integration in ic-js a bit easier.