search

dfinity / interface-spec

IC Interface Specification
https://khsfq-wqaaa-aaaak-qckvq-cai.icp0.io/docs
37 stars 20 forks source link

[FINAL] feat: wasm_memory_persistence option for canister upgrades #281

Closed mraszyk closed 6 months ago

mraszyk commented 8 months ago

This PR adds an option (called wasm_memory_persistence) for canister upgrades. If this option is set, then the WebAssembly memory of the old canister is preserved across the upgrade.

mraszyk commented 8 months ago

@luc-blaeser Is it important to distinguish between "WebAssembly state" and "WebAssembly memory state"? I saw you suggested inserting "memory" and I wonder why you made the suggestion.

luc-blaeser commented 8 months ago

@luc-blaeser Is it important to distinguish between "WebAssembly state" and "WebAssembly memory state"? I saw you suggested inserting "memory" and I wonder why you made the suggestion.

It is not important. I only thought that the binary will be replaced (with its contained passive data segments).

ulan commented 8 months ago

Redirecting the review to @eust-dfinity and @alexandru-uta