search

dfinity / interface-spec

IC Interface Specification
https://khsfq-wqaaa-aaaak-qckvq-cai.icp0.io/docs
37 stars 20 forks source link

[FINAL] feat: [EXC-1676] add allowed viewers variant to canister's log visibility #326

Closed maksymar closed 1 month ago

maksymar commented 4 months ago

This PR adds allowed_viewers variant to canister's log_visibility which allows to fetch logs by specified number of principals.

mraszyk commented 4 months ago

One more point from the Interface spec meeting: should the canister itself be allowed to fetch the logs implicitly, just like it can fetch the canister status even if the canister does not control itself?

dsarlis commented 4 months ago

One more point from the Interface spec meeting: should the canister itself be allowed to fetch the logs implicitly, just like it can fetch the canister status even if the canister does not control itself?

As long as we don't allow fetch_canister_logs through composite queries then the canister cannot really fetch the logs. Or you mean that the canister would make an HTTPS outcall to fetch the logs? I doubt that would be particularly useful to anyone.

mraszyk commented 3 months ago

Or you mean that the canister would make an HTTPS outcall to fetch the logs?

That won't work implicitly anyway as the HTTPS outcall would have a self-authenticating caller that would need to be whitelisted explicitly.

mraszyk commented 1 month ago

@dfx-json The PR looks good to me, but the feature is still disabled in production so I haven't approved yet.