dfinity / linkedup

An open professional network.
https://sdk.dfinity.org
Apache License 2.0
154 stars 43 forks source link

refactor: Use UserLib identity and Caller [SDK-701] #5

Closed ghost closed 4 years ago

ghost commented 4 years ago

Overview

The addition of pulling caller ID from the request and leaning on UserLib for identity management opens the door to simplifying much of our canister code. This PR attempts to streamline the profile API down to the actual business logic, removing much of the message construction and parsing mechanisms.

Also, to prepare for hiding addresses (which I don't feel should be user-facing) I made the search by first and last name.

Changes

ghost commented 4 years ago

Work in progress while I get tests passing.

ghost commented 4 years ago

Current hypothesis on the tests is that CI needs a newer version of dfx .

ghost commented 4 years ago

Ready for review since the master build is also failing.

ghost commented 4 years ago

Merging after getting verbal approval from Enzo this afternoon.

ghost commented 4 years ago

Oh wait. Not building with the latest dfx. Hold up.

hansl commented 4 years ago

Travis hasn’t worked ever as far as I know on this repo.

ghost commented 4 years ago

There was actually a change in Prim that I hadn't accounted for. All good now.