search

dfinity / motoko-base

The Motoko base library
Apache License 2.0
484 stars 99 forks source link

Style guide violation #488

Open timohanke opened 1 year ago

timohanke commented 1 year ago

https://github.com/dfinity/motoko-base/blob/5c9145e79bf471fb662b9b4028937783e97e23d1/src/Buffer.mo#L68

As far as I understand the style guidelines this should be size_ not _size because _size suppresses a compiler warning.

crusso commented 1 year ago

True, but, FTR, haven't implemented that (unused identifier) warning yet ...