When a Playwright e2e test fails, we upload the failure results to GitHub so we can debug the failed test.
The e2e tests are run in 2 separate shards.
But the name for the uploaded failure results is the same for both shards.
So if both shards fail, one of the failure results overrides the other and we can only debug one of the shards.
Changes
Include the shard number in the failure results artifact name.
Motivation
When a Playwright e2e test fails, we upload the failure results to GitHub so we can debug the failed test. The e2e tests are run in 2 separate shards. But the name for the uploaded failure results is the same for both shards. So if both shards fail, one of the failure results overrides the other and we can only debug one of the shards.
Changes
Include the shard number in the failure results artifact name.
Tests
Deliberately made both shards fail in this run and checked that there were 2 separate failure results artifacts: https://github.com/dfinity/nns-dapp/actions/runs/10632674253
Todos