dfinity / nns-dapp

The Dapp of the Internet Computer's Network Nervous System.
https://nns.ic0.app/
Other
110 stars 37 forks source link

Rename PRE_MIGRATION_LIMIT to ACCOUNT_LIMIT #5381

Closed dskloetd closed 2 weeks ago

dskloetd commented 2 weeks ago

Motivation

The account limit was put in place to limit the number of accounts before the migration to stable memory. But we want to keep the account limit in place to mitigate attacks, even with accounts in stable memory.

Changes

Rename PRE_MIGRATION_LIMIT to ACCOUNT_LIMIT and change the comment to make sure the limit doesn't get removed as part of the migration cleanup.

Tests

Existing tests pass.

Todos