search

dfinity / oisy-wallet

A browser-based, multi-chain wallet hosted on the Internet Computer
https://oisy.com
Apache License 2.0
93 stars 17 forks source link

Make index canister as optional #2883

Open tcpim opened 2 days ago

tcpim commented 2 days ago

Is your feature request related to a problem? Please describe.

I love the progress on Oisy! I am confident that Oisy has the potential to be the dominant self custodial wallet in IC ecosystem. For Defi users, it is critical to import any tokens with just the ledger canister because not all tokens have index canister. Say there is a new popular meme token and people want to use Oisy in ICPSwap to trade it, we need to import the token no matter if it has the index canister.

Describe the solution you'd like Just like the new feature in NNS https://www.youtube.com/watch?v=zcXmarBk2L4, Oisy can convey a clear message that without index canister, you won't be able to see the transaction history.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Congrats on the good work so far! Oisy has a really huge potential, especially with the ability to connect via WalletConnect to connect to the outside world. But first, the most wanted feature in IC right now is a easy to use and reliable self custody wallet for Defi. Plug and Stoic is no longer good. And we need Oisy to take the lead. Thank you!

tcpim commented 2 days ago

Also added a forum post here https://forum.dfinity.org/t/can-oisy-support-only-ledger-canister/36185. Thanks!

AntonioVentilii-DFINITY commented 2 days ago

@tcpim Thank you for the suggestion and the praises! Eheh! The entire team (and beyond) is working very hard on the project and it is always good to hear feedbacks!

Regarding the feature, we are including it in our backlog, and we will try to scope it as soon as it we are able to; we will keep you informed

tcpim commented 1 day ago

@AntonioVentilii-DFINITY Does Oisy have plan to let IC Dapp to connect to Oisy? Wondering what would be the experience. Do users need to approve/sign when initiate a transfer after connect to Oisy?

peterpeterparker commented 1 day ago

Does Oisy have plan to let IC Dapp to connect to Oisy?

@tcpim Yes, we are currently reviewing the necessary work for this.

Do users need to approve/sign when initiate a transfer after connect to Oisy?

Yes, the process is similar to the flow you might already be familiar with in other wallets.

On our side, the work is still in progress, and the related library will soon be open-sourced. In the meantime, you can check out Identity Kit, which is a client for the new ICRC standards. These capabilities are being built on top of those standards.

Side note: It’s probably best not to deviate from the original request of this issue, otherwise we might end up with a long thread of various unrelated things. Start a post on the forum or a feature request if you have more quetions. Hope it makes sense.