search

dfinity / rosetta-node

A passive node of the IC that can be interacted with using the Rosetta protocol
Other
8 stars 4 forks source link

breaking change in /construction/derive #6

Open Ljzn opened 2 years ago

Ljzn commented 2 years ago

Hi, we're using the Dfinity rosetta node in production, and we noticed a breaking change in protocol recently.

Before version v1.2.0, the /construction/derive/ can be called without metadata. After v1.2.0, there will be an error said "account_type is missing".

The reason might be this code: https://github.com/dfinity/rosetta-node/blob/f33f0131588b52883bc00f600775b944cfed7774/rosetta-api/src/models.rs#L577

We suggest note the breaking changes like this in document or changelog.