dfinity / sdk

IC SDK: a Software Development Kit for creating and managing canister smart contracts on the ICP blockchain.
https://internetcomputer.org/developers
Apache License 2.0
174 stars 83 forks source link

Remove all Unicode spinners. #1358

Open p-shahi opened 3 years ago

p-shahi commented 3 years ago

Even when not interrupted by other messages, the “Checking for latest dfx version” message, which is accompanied by a unicode spinner, and should only appear once while the spinner changes, is printed repeatedly.

Back to my own installation, the next quick start step is to create a project.

I run dfx new hello and see similar output to Aimee’s. I’m on Linux and I too see the duplicate status messages with spinners:

⠴ Installing node dependencies...
⠠ Installing node dependencies...
npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
⠦ Installing node dependencies...
⠐ Installing node dependencies...
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@~2.3.1 (node_modules/chokidar/node_modules/fsevents):
Maybe node is printing empty lines here and that’s causing the spinner to be interrupted, or maybe it’s somehow just from node printing a line.
hansl commented 3 years ago

Wrong issue; the interaction between npm and a spinner is wrong, but that doesn't make spinners wrong.

We can either;

hansl commented 3 years ago

I vote for the second one.

sesi200 commented 2 years ago

Internal ticket: SDK-755