dfinity / sdk

IC SDK: a Software Development Kit for creating and managing canister smart contracts on the ICP blockchain.
https://internetcomputer.org/developers
Apache License 2.0
170 stars 82 forks source link

refactor: more idiomatic identity override #3743

Closed ericswanson-dfinity closed 3 months ago

ericswanson-dfinity commented 3 months ago

Description

Changes the signature of Environment::get_identity_override() and IdentityManager::new() to be more idiomatic rust, using Option<&str> rather than &Option<String>.

The motivation is in consideration of another caller of IdentityManager::new(), which may pass None for the identity override.

How Has This Been Tested?

Refactor covered by e2e