search

dfinity / sdk

IC SDK: a Software Development Kit for creating and managing canister smart contracts on the ICP blockchain.
https://internetcomputer.org/developers
Apache License 2.0
170 stars 82 forks source link

fix: Capitalization of "Wasm" #3756

Closed ulan closed 3 months ago

ulan commented 3 months ago

This replaces incorrect capitalization of "WASM" with "Wasm", which is the official abbreviation of WebAssembly.

See: https://webassembly.org/

The reason why not all letters are capitalized is because "Wasm" is not an acronym, but rather an abbreviation.

This change also fixes capitalization of the canister status output to be consistent wih other fields.

ulan commented 3 months ago

@ericswanson-dfinity: thanks for the fast review! To double check: is it safe to change the user facing messages this way? I was wondering it that could break some scripts.

ericswanson-dfinity commented 3 months ago

@ericswanson-dfinity: thanks for the fast review! To double check: is it safe to change the user facing messages this way? I was wondering it that could break some scripts.

It's always possible that changing the output of a program could break some scripts. I suppose you could call out the change to dfx canister status output in the changelog.