dfinity / sdk

IC SDK: a Software Development Kit for creating and managing canister smart contracts on the ICP blockchain.

https://internetcomputer.org/developers

Apache License 2.0

170 stars 82 forks source link

refactor: add host and artifical-delay only if not passed #3757

Closed ericswanson-dfinity closed 3 months ago

ericswanson-dfinity commented 3 months ago

Description

This part of dfx_start has always bothered me. If there are no parameters it uses a dynamic port, but any parameter means use the fixed port? No.

Main motivation: I want to use --artificial-delay to force a configuration change. But I can't pass it because it's always passed by this method.

How Has This Been Tested?

If the e2e tests pass, it works

Checklist:

[x] The title of this PR complies with Conventional Commits.
[ ] I have edited the CHANGELOG accordingly.
[ ] I have made corresponding changes to the documentation.