dfinity / sdk

IC SDK: a Software Development Kit for creating and managing canister smart contracts on the ICP blockchain.

https://internetcomputer.org/developers

Apache License 2.0

170 stars 82 forks source link

fix!: sync .well-known dir by default #3759

Closed sesi200 closed 3 months ago

sesi200 commented 3 months ago

Description

Well-founded complaint:

May I ask what's the reasoning between not allowing .well-known folder per default and forcing each developers to whitelist this folder in ic-assets.json? I had to answer and explain countless time, often per private message, how to set up such a file. It's becoming annoying, particularly when I'm pinged late in the evening, therefore I am curious to know if there is a valid reason.

This PR automatically adds .well-known to the list of synced directories

Inspired quite a bit by #2948

How Has This Been Tested?

Added unit tests

Checklist:

[x] The title of this PR complies with Conventional Commits.
[x] I have edited the CHANGELOG accordingly.
[ ] I have made corresponding changes to the documentation.