dfinity / sdk

IC SDK: a Software Development Kit for creating and managing canister smart contracts on the ICP blockchain.
https://internetcomputer.org/developers
Apache License 2.0
170 stars 82 forks source link

fix: --initial-margin for dfx canister delete #3769

Closed sesi200 closed 3 months ago

sesi200 commented 3 months ago

Description

dfx canister delete occasionally fails because it attempts to withdraw too many cycles from the canister before it is deleted. Usually, dfx tries again with a larger margin of cycles, but sometimes this gets stuck. It is now possible to use --initial-margin to manually supply a margin in case the automatic margin does not work.

This is a temporary workaround until a clean solution exists (requires spec change, runtime change, wallet change, agent support).

Fixes SDK-1556

How Has This Been Tested?

Tested manually on mainnet

Checklist: