dfinity / sdk

IC SDK: a Software Development Kit for creating and managing canister smart contracts on the ICP blockchain.
https://internetcomputer.org/developers
Apache License 2.0
171 stars 83 forks source link

fix: flaky test due to panic in http gateway #3884

Closed ericswanson-dfinity closed 3 weeks ago

ericswanson-dfinity commented 3 weeks ago

Description

The new http gateway has some unwrap() calls instead of error checking, and panics on connect failure. This surfaces in the two tests that this PR updates.

The result is that dfx has to restart the http gateway more than once, until it finally comes up after the replica is healthy. Sometimes this exceeds the 15 second timeout in these tests.

The panics are fixed in https://github.com/dfinity/ic/pull/1029 but that fix will take a while to land here.

How Has This Been Tested?

See test failures and later successes in the commits on branch https://github.com/dfinity/sdk/commits/ens/check-flaky-test/

Checklist: