search

dfinity / sns-testing

Testing SNS in local testing environment
Apache License 2.0
9 stars 12 forks source link

add sns_lifecycle.yml #33

Closed mraszyk closed 1 year ago

mraszyk commented 1 year ago

This PR builds the sns-testing Docker image and runs the basic scenario in it. It also adds a few Bash scripts for awaiting NNS/SNS proposals and canisters to be in running state.

aterga commented 1 year ago

Thanks for the PR, @mraszyk !

IIUC, this pipeline ensures that there is a version of Ubuntu on which the sns-testing scripts work. However, directly running on Ubuntu is not one of the recommended workflows described in the README.md file.

I think if we decide that sns-testing CI is important, we should build a pipeline that runs the Docker-based solution. This should be rather straightforward, as one would not need to explicitly install any dependencies. So typically a docker-based solution has a CI pipeline that:

  1. Builds a docker image from the latest commit.
  2. Starts the Docker image and runs some tests.
  3. If we're on the main branch and the tests succeed, it then publishes the image to Dockerhub.
aterga commented 1 year ago

Could we factor out the Docker publishing step from this PR into a separate one?

I think we could already merge this (modulo logging into the Docker account), and it would be beneficial for us to do that ASAP. Wdyt @mraszyk ?

mraszyk commented 1 year ago

Could we factor out the Docker publishing step from this PR into a separate one?

Indeed. Done.