search

dfinity / sns-testing

Testing SNS in local testing environment
Apache License 2.0
9 stars 12 forks source link

feat: NNS1-2346: Added propose_sns.sh. #35

Closed daniel-wong-dfinity-org closed 1 year ago

daniel-wong-dfinity-org commented 1 year ago

Closes NNS1-2346.

daniel-wong-dfinity-org commented 1 year ago

Woops. Accidentally closed. I got confused because I hardly use Github. Almost all my work is in Gitlab.

Anyway, implementing suggestions on most items. I'll request re-review pretty soon (before lunch?).

aterga commented 1 year ago

LGTM, but please consider the comments regarding participate_sns_swap.sh before you merge.