dfinity / sns-testing

Testing SNS in local testing environment
Apache License 2.0
9 stars 12 forks source link

change the directory to repository's root in scripts #9

Closed mraszyk closed 1 year ago

mraszyk commented 1 year ago

This PR makes the following changes:

aterga commented 1 year ago

Has this been tested (1) with the docker solution, (2) the native- macOS instructions, or both?

mraszyk commented 1 year ago

Has this been tested (1) with the docker solution, (2) the native- macOS instructions, or both?

I've successfully run the basic scenario in docker at the latest commit 4032ace. I haven't tested on macOS as I don't have one.

aterga commented 1 year ago

Has this been tested (1) with the docker solution, (2) the native- macOS instructions, or both?

I've successfully run the basic scenario in docker at the latest commit 4032ace. I haven't tested on macOS as I don't have one.

Great, thanks. Then I'll test on Apple Silicon, and if we works as expected, I think we can merge this MR.

aterga commented 1 year ago

Progress so far:

Error: Failed to get frontend address.
Caused by: Failed to get frontend address.
  Failed to find reusable socket address
    Failed to set socket of tcp builder to 0.0.0.0:8080.
      Address already in use (os error 98)
aterga commented 1 year ago

Step 3 in "SNS lifecycle" needs to be adjusted slightly:

[nix-shell:~/sns-testing]$ ./bin/dfx canister id test
bash: ./bin/dfx: No such file or directory

[nix-shell:~/sns-testing]$ dfx canister id test
by6od-j4aaa-aaaaa-qaadq-cai
aterga commented 1 year ago

Nit: step 6 should provide sane example values for ./participate_sns_swap.sh <num-participants> <icp-per-participant>

aterga commented 1 year ago

Step 6 in "SNS lifecycle"

Running

[nix-shell:~/sns-testing]$ ./participate_sns_swap.sh 2 10
Using identity: "default".
Using identity: "default".
Error: Identity already exists.
Using identity: "participant-000".
Using identity: "icp-ident-RqOPnjj5ERjAEnwlvfKw".
Transfer sent at block height 24
Using identity: "participant-000".
...

I was wondering if the error indicates that something didn't go as expected. If it's expected, maybe we could mention that as a not in the README instructions.

aterga commented 1 year ago

Also step 6:

How can I get the account of e.g., participant-001?

aterga commented 1 year ago

Step 7: there should be a note explaining that the sale finalization will expectedly fail if the participation is insufficient:

(
  record {
    set_dapp_controllers_call_result = null;
    settle_community_fund_participation_result = null;
    error_message = opt "The Sale can only be finalized in the COMMITTED or ABORTED states. Current state is Open";
    set_mode_call_result = null;
    sweep_icp_result = null;
    claim_neuron_result = null;
    sweep_sns_result = null;
  },
)
aterga commented 1 year ago

Is it safe to run the ./participate_sns_swap.sh multiple times?

mraszyk commented 1 year ago

Thank you for the feedback! It's addressed in https://github.com/dfinity/sns-testing/pull/21 and https://github.com/dfinity/sns-testing/pull/26.