Closed mraszyk closed 1 year ago
Has this been tested (1) with the docker solution, (2) the native- macOS instructions, or both?
Has this been tested (1) with the docker solution, (2) the native- macOS instructions, or both?
I've successfully run the basic scenario in docker at the latest commit 4032ace. I haven't tested on macOS as I don't have one.
Has this been tested (1) with the docker solution, (2) the native- macOS instructions, or both?
I've successfully run the basic scenario in docker at the latest commit 4032ace. I haven't tested on macOS as I don't have one.
Great, thanks. Then I'll test on Apple Silicon, and if we works as expected, I think we can merge this MR.
Progress so far:
If the 8080 port is occupied, the first step inside Nix will fail. One should run docker ps
and lsof -i :8080
to determine which process or container needs to be terminated.
Symptoms:
Error: Failed to get frontend address.
Caused by: Failed to get frontend address.
Failed to find reusable socket address
Failed to set socket of tcp builder to 0.0.0.0:8080.
Address already in use (os error 98)
Basic scenario has successfully finished.
!Step 3 in "SNS lifecycle" needs to be adjusted slightly:
[nix-shell:~/sns-testing]$ ./bin/dfx canister id test
bash: ./bin/dfx: No such file or directory
[nix-shell:~/sns-testing]$ dfx canister id test
by6od-j4aaa-aaaaa-qaadq-cai
Nit: step 6 should provide sane example values for ./participate_sns_swap.sh <num-participants> <icp-per-participant>
Step 6 in "SNS lifecycle"
Running
[nix-shell:~/sns-testing]$ ./participate_sns_swap.sh 2 10
Using identity: "default".
Using identity: "default".
Error: Identity already exists.
Using identity: "participant-000".
Using identity: "icp-ident-RqOPnjj5ERjAEnwlvfKw".
Transfer sent at block height 24
Using identity: "participant-000".
...
I was wondering if the error indicates that something didn't go as expected. If it's expected, maybe we could mention that as a not in the README instructions.
Also step 6:
How can I get the account of e.g., participant-001
?
Step 7: there should be a note explaining that the sale finalization will expectedly fail if the participation is insufficient:
(
record {
set_dapp_controllers_call_result = null;
settle_community_fund_participation_result = null;
error_message = opt "The Sale can only be finalized in the COMMITTED or ABORTED states. Current state is Open";
set_mode_call_result = null;
sweep_icp_result = null;
claim_neuron_result = null;
sweep_sns_result = null;
},
)
Is it safe to run the ./participate_sns_swap.sh
multiple times?
Thank you for the feedback! It's addressed in https://github.com/dfinity/sns-testing/pull/21 and https://github.com/dfinity/sns-testing/pull/26.
This PR makes the following changes:
source open_sns_sale.sh
)upgrade_dapp.sh
rundfx build
commands from where the script is executed, e.g., the project-specific/dapp
directory, and accept a path to a file containing binary-encoded post-upgrade argumentsdeveloper_neuron_id.sh
script printing the developer neuron ID to stdoutidl2json
,jq
, andpython3
to derive SNS neuron IDs