search

dfinity / snsdemo

Developer focused SNS deployment demo
15 stars 6 forks source link

Allow calling bin/dfx-sns-demo-mksns from another directory #361

Closed dskloetd closed 4 months ago

dskloetd commented 4 months ago

Motivation

dfx-sns-demo-mksns is used to create SNSes while a snapshot is created. It could also be useful to add SNSes to an existing running snapshot. In that case we'd want to run dfx-sns-demo-mksns from an nns-dapp repo.

Changes

  1. Do not assume ../bin-other (which is created by dfx-sns-demo) exists.
  2. Don't cd into the snsdemo directory.
  3. Call dfx-sns-config-random from path instead of ./bin.
  4. Make sure logo.png is present in the current directory when sns propose is called.

Tested

  1. Creating a snapshot still work.
  2. Tried creating an SNS from nns-dapp repo into an existing snapsho.