dfinity / snsdemo

Developer focused SNS deployment demo
15 stars 6 forks source link

Use access token GIX_CREATE_PR_PAT instead of GIX_SNSDEMO_BOT_GH_TOKEN #393

Closed dskloetd closed 1 month ago

dskloetd commented 1 month ago

Motivation

The latest run to update the IC commit in snsdemo, had the following error:

fatal: could not read Username for 'https://github.com': No such device or address

After some searching, I found this, indicating that this is an issue with the access token.

After switching from GIX_SNSDEMO_BOT_GH_TOKEN to GIX_CREATE_PR_PAT, the issue went away. We already use GIX_CREATE_PR_PAT in nns-dapp, ic-js and gix-components so it seems fine to use in snsdemo as well. The snsdemo repo already had access to the token.

Changes

Change the version of peter-evans/create-pull-request that we use from v4 to v5.

Tests

Ran the workflow from the branch and it succeeded: https://github.com/dfinity/snsdemo/actions/runs/10556505138/job/29242171471 And it created this PR: https://github.com/dfinity/snsdemo/pull/392