Open matthewhammer opened 2 years ago
This PR is still a draft, but it may be ready enough for initial feedback from @kritzcreek, for an initial sanity check. Going to change to "ready for review", even though there is probably more to do before reviewing fully.
Hey, I agree this is a desirable feature. I'm a bit worried about breaking all the package-sets we've put out there so far. Maybe we could make the parameter non-optional, but continue to try and parse the old format for a while? While emitting a warning that we defaulted the path
configuration to src
for all the packages that were missing it?
Just a suggestion, if you think it's better to rip off the bandaid, I'm happy to approve.
Maybe we could make the parameter non-optional, but continue to try and parse the old format for a while? While emitting a warning that we defaulted the path configuration to src for all the packages that were missing it?
Okay, I like that idea, and concurrently I had begun to sour on the optional-ness of path
, and wanted to also make it mandatory, where people would write "src"
to get the current behavior. This evolution path seems natural and good to me! Thanks for taking a look!
Hi @matthewhammer, any plans to pick this up again? Do you need a hand?
37