dfinity / wg-identity-authentication

Repository of the Identity and Wallet Standards Working Group
https://wiki.internetcomputer.org/wiki/Identity_%26_Authentication
Apache License 2.0
28 stars 9 forks source link

added canister-based-wallet-architects.md and diagram pic #10

Closed neeboo closed 6 months ago

neeboo commented 1 year ago

canister based wallet architects and diagram

neeboo commented 1 year ago

And maybe just a general question: Do you expect the IDP front end to spawn the wallet canister or should it be that each use can also bring their own wallet as long as it implements the required interfaces? I think this would be an awesome for giving full control to the users (i.e. build your own if you don't trust the default wallet implementation).

I would choose the latter if possible, however maybe we need some registry to query wallet list from his/her controller principal id. But maybe we can allow users to input and save their wallet canister id with owner check.

marydwyer commented 1 year ago

Thanks for the great proposal @neeboo! I'm looking forward to continuing to collaborate on it. A couple of notes:

neeboo commented 1 year ago

Thanks for the great proposal @neeboo! I'm looking forward to continuing to collaborate on it. A couple of notes:

  • I'm having a hard time following the diagram. You illustrate the elements of the wallet canister very well. However, I'd like to see the user, dapp A, dapp B, and identity provider and understand when the user is using their principal for dapp A, dapp B or their delegation identity principal (DIP). I am not following the relationship between the wallet canister, targets, and frontend.
  • Does this solution depend on the development of any other technologies? If so, could we add a dependencies section?

I have a little demo showing here: https://github.com/AstroxNetwork/wallet_call

frederikrothenberger commented 6 months ago

Given this PR has not made progress in over a year, I think it is appropriate to close it. Feel free to reopen if you disagree.