ICRC-32: Fix delegations data structure

dfinity / wg-identity-authentication

Repository of the Identity and Wallet Standards Working Group

https://wiki.internetcomputer.org/wiki/Identity_%26_Authentication

Apache License 2.0

31 stars 9 forks source link

ICRC-32: Fix delegations data structure #135

Closed sea-snake closed 7 months ago

sea-snake commented 8 months ago

Fix delegations data structure, make sure that delegation field is explicitly defined as defined in the IC spec. Also renames top level optional delegation field to delegations to indicate it's a list of delegations.

One question here, what encoding do we use for blobs here? I assume base64 like other binary data in other icrc25 extension. In that case we should probably specify that. Right now the different icrc25 extensions define a mix of blob, text and other types in their docs.

frederikrothenberger commented 7 months ago

@sea-snake : I took the liberty of implementing the review feedback myself in order to unblock the alignment with recent changes in ICRC-25. Feel free to reach out, create another PR, etc if I missed something.