search

dfinity / wg-identity-authentication

Repository of the Identity and Wallet Standards Working Group
https://wiki.internetcomputer.org/wiki/Identity_%26_Authentication
Apache License 2.0
26 stars 8 forks source link

ICRC-32: Simplify result and avoid duplication of delegation field name #154

Closed frederikrothenberger closed 4 months ago

frederikrothenberger commented 4 months ago

This simplifies the result by flattening the outermost object. This object was initially created because the method used to be able to provide multiple signatures (which is no longer the case to avoid complexity).

In addition, the outermost delegation field is renamed to signer_delegation. This is consistent with sender_delegation in the canister call envelope and avoids having multiple delegation fields on different hierarchy levels.

frederikrothenberger commented 4 months ago

LGTM, thanks! nits: the PR description seems to have some typos: "simplifys"-> "simplifies", "cause" -> "case"

Thanks 🙈