dfinity / wg-identity-authentication

Repository of the Identity and Wallet Standards Working Group
https://wiki.internetcomputer.org/wiki/Identity_%26_Authentication
Apache License 2.0
28 stars 9 forks source link

ICRC-25: Remove app and wallet metadata #45

Closed frederikrothenberger closed 11 months ago

frederikrothenberger commented 11 months ago

This PR removes app and wallet metadata from the permission request.

Reason: the currently gives no way to verify the supplied information. Any way of verifying the app or wallet metadata is dependent on the transport used. For this reason, the exchange of appMetadata should be handled by the transport standard.

jsamol commented 11 months ago

I believe you also should remove walletMetadata from the response. I forgot we had opted for removing it and renamed it according to the feedback 😅

frederikrothenberger commented 11 months ago

@jsamol: I have now removed the wallet metadata too.