dfinity / wg-identity-authentication

Repository of the Identity and Wallet Standards Working Group
https://wiki.internetcomputer.org/wiki/Identity_%26_Authentication
Apache License 2.0
31 stars 9 forks source link

ICRC-25: Split out identity information from `icrc25_request_permission` method #79

Closed frederikrothenberger closed 11 months ago

frederikrothenberger commented 11 months ago

This PR splits the identitiy information part of the existing icrc25_request_permission method into another method called icrc25_get_identities. This makes the methods more focused.

The PR also adds clarifying information about how user interaction should be handled for the given methods. In particular, it allows signers to skip user interaction if the user previously approved the same request.

frederikrothenberger commented 11 months ago

I guess I'm missing something, but previously it was clear that the permission (e.g. for the scope icrc25_canister_call) is issued for the identities included in the response. With the current change, when we have two separate calls, it is not clear which identities are meant for which permissions. Maybe add an example with a typical interplay of the scopes? Or maybe we can discuss it next week?

The selection of identities and the permission scopes granted are orthogonal. This was also the case previously, but making it two separate calls makes this more explicit.

Both, identities and permission scopes are selected / granted for a specific session. And both of these things can change independently over the lifetime of that session.

I.e.: