Fix module installation path

dfinke / InstallModuleFromGitHub

Install PowerShell Modules from GitHub

Apache License 2.0

87 stars 31 forks source link

Fix module installation path #16

Closed JonathanPitre closed 4 years ago

JonathanPitre commented 4 years ago

There's an issue with the latest release. The installation path for the module is wrong. It contains the parent folder instead of just the content of the archive.

Here's the fix:

Line 82 $null = Copy-Item "$(Join-Path -Path $tmpDir -ChildPath $unzippedArchive\*)" $dest -Recurse -Force

dfinke commented 4 years ago

Thanks. I published this from my new machine with the same workflow. I'll publish it from the old box and investigate.

dfinke commented 4 years ago

Installed from the gallery, couldn't repro.

JonathanPitre commented 4 years ago

Try this

Install-ModuleFromGitHub -GitHubRepo JonathanPitre/PSAppDeployToolkit

dfinke commented 4 years ago

Sorry, thought it was doing it from the gallery. Not sure when I'll be able to get to this. If you figure out, submit a PR.

JonathanPitre commented 4 years ago

The fix is simply to change line 81 to this:

$null = Copy-Item "$(Join-Path -Path $tmpDir -ChildPath $unzippedArchive\*)" $dest -Force-Recurse`

I tried to create a pull reques but I keep gettting an error.

fatal: TypeLoadException encountered. Method 'DeleteCredentials' in type 'Atlassian.Bitbucket.Authentication.Authentication' from assembly 'Bitbucket.Authentication, Version=1.2.0.0, Culture=neutral, PublicKeyToken=null' does not have an implementation. remote: Permission to dfinke/InstallModuleFromGitHub.git denied to JonathanPitre.

dfinke commented 4 years ago

Fixed by #18